Fix: Feed notification #117
Merged
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y0urself
reviewed
Sep 30, 2024
y0urself
reviewed
Oct 1, 2024
Co-authored-by: Jaspar Stach <[email protected]>
y0urself
reviewed
Oct 2, 2024
Co-authored-by: Jaspar Stach <[email protected]>
|
Searched through all the feed repositories, only greenbone-feed-sync/.github/workflows/push.yml might need adaption, see: greenbone/greenbone-feed-sync#232 |
y0urself
reviewed
Oct 4, 2024
Co-authored-by: Jaspar Stach <[email protected]>
y0urself
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change notification-channel for notify-mattermost-2nd-gen.yml
Adapt if conditions when using notify-mattermost* workflows
Why
Currently https://github.com/greenbone/workflows/blob/main/.github/workflows/notify-mattermost-2nd-gen.yml#L36 notifies in channel: PD:2ndGenDeployment but should be TOD:FeedDeployment:Notification
Also check and adapt the if conditions for all workflows in greenbone/workflows using the notify-mattermost-2nd.gen workflow -> They should be run on every build.
References
https://jira.greenbone.net/browse/DEVOPS-1254